Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nana to nushell 0.90.1 and Tauri 1.6 #78

Merged
merged 13 commits into from
Mar 5, 2024
Merged

update nana to nushell 0.90.1 and Tauri 1.6 #78

merged 13 commits into from
Mar 5, 2024

Conversation

cablehead
Copy link
Contributor

@cablehead cablehead commented Mar 5, 2024 •
edited
Loading

There's likely more things that need updating, but this allows nana to build, and basic ls etc are working.

@cablehead cablehead changed the title WIP: update nana to nushell 0.90.1 and Tauri 1.4 WIP: update nana to nushell 0.90.1 and Tauri 1.6 Mar 5, 2024
@cablehead cablehead changed the title WIP: update nana to nushell 0.90.1 and Tauri 1.6 update nana to nushell 0.90.1 and Tauri 1.6 Mar 5, 2024
@cablehead cablehead marked this pull request as ready for review March 5, 2024 19:37
@fdncred
Copy link
Collaborator

fdncred commented Mar 5, 2024 •
edited
Loading

Not bad. Thanks! It's nice to play with it again!

I was hoping sys would work and $nu. Those are usually interesting looking.
image

LOL. scope commands makes it run home to momma. I'm not sure what it's doing but it breaks it.

@fdncred
Copy link
Collaborator

fdncred commented Mar 5, 2024 •
edited
Loading

Seems like the ansi escape sequence parsing isn't working anymore? Maybe it never worked? (but it worked with the $nu example?)
image

@rgwood
Copy link
Contributor

rgwood commented Mar 5, 2024

I was hoping sys would work and $nu. Those are usually interesting looking. image

Ah, darn. LazyRecord should be an easy short-term fix, we can just collect it into a Record before serializing. Doesn't need to happen in this PR though!

rgwood
rgwood approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@rgwood rgwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, thank you so much for this! Will be nice to have Nana usable again.

@rgwood rgwood merged commit 70d681c into nushell:main Mar 5, 2024
6 checks passed
@cablehead
Copy link
Contributor Author

cablehead commented Mar 6, 2024 •
edited
Loading

Thanks for the merge @rgwood! I'll take a shot at the Lazy Record, either today or tomorrow. I'm curious to explore nu's inner data types! @fdncred if you notice more small issues, let me know and I'll look at touching those up too.

@cablehead cablehead deleted the restore branch March 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgwood rgwood rgwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cablehead @fdncred @rgwood